bump version to 0.6.12#3388
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the version string in ChangesVersion Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Review: Bump version to 0.6.12 - The diff is a single-line change (0.6.11 -> 0.6.12) and is correct. Review notes below. |
|
Version Bump Assessment The single-line diff (version.txt: 0.6.11 -> 0.6.12) is correct. Per the project versioning scheme, patch covers small backwards-compatible features and bug fixes. Most of the bundled changes (new APIs, additive parameter widening) fit this rule. Two items stand out as potentially breaking: 1. b12x_fused_moe removed parameters (quant_mode, source_format) — any caller passing these keyword arguments will get a TypeError at runtime. If this is part of the public API surface, this warrants a minor bump (0.7.0) or at minimum a deprecation cycle before removal. 2. create_cudnn_execution_plans_mxfp8_gemm renamed to build_cudnn_gemm_mxfp8_graph — the old name disappears entirely. The diff context suggests it is an @lru_cache internal helper, so impact may be limited — but confirming it is not re-exported publicly before tagging would be good. If both affect downstream public users, 0.7.0 is more appropriate. If strictly internal, 0.6.12 is fine — just note them in the release changelog to avoid downstream surprises. |
|
Observations on Bundled Changes (from PR description)
Summary: The diff is correct. The main open question before merging is whether the b12x_fused_moe parameter removal and the cuDNN function rename are public-facing breaks (-> 0.7.0) or strictly internal (0.6.12 is fine). Also worth a quick check that checkpointing_ssu and fused_qk_rmsnorm_rope have trace templates wired up as project conventions require. |
|
/bot run |
Description
Bump version to 0.6.12 for release.
Related Issues (Gated-by PRs)
https://github.com/flashinfer-ai/flashinfer/issues?q=is%3Aopen+label%3Av0.6.12
Reviewer Notes
API changes review
API changes since v0.6.11.post3, using new tool
API changes since v0.6.11.post3 (old approach)
Supplemental:
trtllm_batch_decode_with_kv_cache/trtllm_batch_context_with_kv_cachegainedlseandreturn_lseparameters (signature widening — BC)$ git diff v0.6.11.post3..main -- "flashinfer/decode.py" "flashinfer/prefill.py" | grep -B3 -A6 "return_lse: bool = False" uses_shared_paged_kv_idx: bool = True, -) -> Union[torch.Tensor, FP4Tensor]: + lse: Optional[torch.Tensor] = None, + return_lse: bool = False, +) -> Union[ + torch.Tensor, FP4Tensor, Tuple[Union[torch.Tensor, FP4Tensor], torch.Tensor] +]: """ Parameters ---------- -- causal: bool = True, -) -> Union[torch.Tensor, FP4Tensor]: + lse: Optional[torch.Tensor] = None, + return_lse: bool = False, +) -> Union[ + torch.Tensor, FP4Tensor, Tuple[Union[torch.Tensor, FP4Tensor], torch.Tensor] +]: """ Parameters ----------Summary by CodeRabbit